Changed MDS to use private Repo - #9
Merged
Merged
Conversation
The mds repo (github.com/minio/mds) is now private. Using the git+ssh:// scheme lets yarn install authenticate via each developer's / CI runner's SSH key without relying on a per-machine `insteadOf` git config or HTTPS token. Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
📝 WalkthroughWalkthroughThe web application manifest changes the ChangesDependency manifest updates
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web-app/package.json`:
- Line 15: Update the mds dependency declaration associated with the "mds"
package entry to use an authenticated HTTPS source, or configure the install
environment with a pinned github.com known_hosts entry and read credentials for
minio/mds. Ensure dependency installation works non-interactively in every
supported environment.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 372abe7c-56b8-43dc-9d6a-e82834118ff7
⛔ Files ignored due to path filters (1)
web-app/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
web-app/package.json
| "lodash": "^4.18.1", | ||
| "luxon": "^3.7.2", | ||
| "mds": "https://github.com/minio/mds.git#v1.1.5", | ||
| "mds": "git+ssh://git@github.com/minio/mds.git#v1.1.5", |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
GIT_SSH_COMMAND='ssh -o BatchMode=yes -o StrictHostKeyChecking=yes' \
git ls-remote ssh://git@github.com/minio/mds.git refs/tags/v1.1.5Repository: miniohq/object-browser
Length of output: 406
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- dependency declaration ---'
sed -n '1,30p' web-app/package.json
printf '%s\n' '--- lockfile references ---'
rg -n -C 3 'mds|400914d72cb3ffa27d600e0ae1f17ece2182ec22|v1\.1\.5|ws' \
web-app/package-lock.json web-app/yarn.lock web-app/pnpm-lock.yaml 2>/dev/null || true
printf '%s\n' '--- HTTPS tag resolution ---'
git ls-remote https://github.com/minio/mds.git \
refs/tags/v1.1.5 refs/tags/v1.1.5^{} || trueRepository: miniohq/object-browser
Length of output: 23950
Configure non-interactive SSH access for every install environment. Dependency resolution fails without a trusted github.com host key and read access to minio/mds; the lockfile does not provide either. Add a pinned known_hosts entry and deploy credentials, or use an authenticated HTTPS source.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web-app/package.json` at line 15, Update the mds dependency declaration
associated with the "mds" package entry to use an authenticated HTTPS source, or
configure the install environment with a pinned github.com known_hosts entry and
read credentials for minio/mds. Ensure dependency installation works
non-interactively in every supported environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.